Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this addon inert on Ember versions with native support for the feature #121

Closed
chancancode opened this issue Apr 14, 2022 · 3 comments · Fixed by #122
Closed

Make this addon inert on Ember versions with native support for the feature #121

chancancode opened this issue Apr 14, 2022 · 3 comments · Fixed by #122
Labels

Comments

@chancancode
Copy link
Collaborator

Once this feature is enabled on the Ember side, this addon should be updated to be completely inert (i.e. have no effect in the consuming app's build output). There is a recent example of that here. I'm not sure if there is a better way to do it that is more Embroider-friendly, but at the end of the day, I am not sure it really matters. If the reason this is using v1 build hooks is to disable itself on modern version of Ember anyway, it seems ok? cc @ef4

@ef4
Copy link

ef4 commented Apr 14, 2022

Yes, the example you linked should be embroider-compatible, and since this package is a v1 addon it's a good pattern for it to use.

@NullVoxPopuli
Copy link
Collaborator

excellent, I can get the auto-removal stuff setup today

NullVoxPopuli added a commit that referenced this issue Apr 14, 2022
feat: make inert when ember-source supports default helper manager

Closes: #121
@github-actions
Copy link

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants