Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix attributes not available in didRender #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

simonihmig
Copy link
Contributor

See #64

@simonihmig simonihmig force-pushed the failing-didrender branch from c11e259 to 557f683 Compare May 1, 2019 16:15
@simonihmig simonihmig changed the title Add failing test for attributes not available in didRender WIP: Fix attributes not available in didRender May 5, 2019
@simonihmig
Copy link
Contributor Author

@rwjblue did a quick naive PoC changing the order in commit() as you suggested in Discord:
image

And indeed that commit makes the previously failing test pass for Ember 2.16 and 2.18!

Ember 3.1 - 3.3 are still failing, as they use a different if-block of the runtime polyfill, and I was not sure how to approach them (also patching the Glimmer environment as in the older versions?). Also the patched commit does not work at all for Ember 2.12.

But at least this seems to confirm your thoughts that the issue is related to the order how modifiers and component hooks are called. I feel I am not really able to efficiently dig further into this, as I am missing too much context about the internals involved here. But hopefully this makes it easier to pick this up? Would you be able to do so? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant