fix: base RecordData creation when creating a projection #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorT
reviewed
Aug 16, 2019
|
Do we expect this to resolve issues on beta? https://travis-ci.org/hjdivad/ember-m3/jobs/573846095 |
|
We do but while the commit has been backported there is not yet a beta cut with it |
|
@runspired got it; thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M3 was relying on an unknown implicit behavior to create new client side records without using createRecord. This broke when
clientIdbegan to be unique across types. This change prepares M3 for versions of EmberData whereclientIdis unique across types when paired with emberjs/data#6334