-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript guides #1960
Add TypeScript guides #1960
Conversation
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started! I left a bunch of suggestions, and I think we want to keep these out of the top-level outline for now, but getting it started this way is awesome, and now we can iterate!
Co-authored-by: Chris Thoburn <[email protected]>
Co-authored-by: Lukas Nys <[email protected]>
Co-authored-by: Jared Galanis <[email protected]>
96c66c3
to
3fefd39
Compare
Lint should be fixed now. I played w/ moving the chapter up a level (per discussion on Discord) and it makes the initial TOC super long + pushes some of the TypeScript chapters to the same level as their top-level equivalent (e.g. "Getting Started" at the same level as "TypeScript: Getting Started") which I found a bit confusing. I also played with splitting up the Invokables chapter and there wasn't a great place to split it (it's written as one narrative that references itself a lot), so I left it as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
While we have grand plans to eventually have a js/ts toggle for all of the guides, we need something to point to in the meantime. In this PR, I am adding initial TypeScript guides pulled from the various resources currently scattered across the interwebs to use as a starting point.
These pages currently will not show up in the table of contents. You'll have to visit the link directly. The purpose of this is to allow us to merge this mega-PR and continue to iterate without being fully released. In the meantime, we can link people directly to these pages with the caveat that the pages are still under construction.
Sources:
This will help us close out emberjs/rfcs#952
To review:
Visit deploy preview linked below and navigate to
./release/using-typescript/
(e.g. https://deploy-preview-1960--ember-guides.netlify.app/release/using-typescript/ for the deploy that was current at the time of this writing)
Review for:
Please make liberal use of the GitHub suggestions feature because I am starting to get bleary-eyed looking at this for so long. 🙏