Sidebar weirdness (#486) #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guidemaker-ember-template ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
added 2 commits
February 5, 2024 11:44
these styles were added to ember-styleguide in ember-learn/ember-styleguide@add121d
IgnaceMaes
requested changes
Feb 7, 2024
In a way this is now more aligned with the ember-styleguide but it does make sense to have it stay the same width. I'll see if I can create a PR to |
lukasnys
force-pushed
the
sidebar-weirdness
branch
from
fbdfe8c to
7544757
Compare
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ember-learn/ember-styleguide#486, there was mention of some negative margin hack.
This PR upgrades to ember-styleguide@10 removes this negative margin.
Based on #172