Merge pull request #173 from IgnaceMaes/gray-edit-icon

style: inline pen svg and make color gray
ember-learn · Feb 22, 2024 · 12e8c50 · 12e8c50
2 parents e297ca4 + 81c5ead
commit 12e8c50
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 18 deletions.
diff --git a/addon/styles/addon.css b/addon/styles/addon.css
@@ -171,6 +171,12 @@ main {
 
 .edit-icon {
   height: 1rem;
+  color: var(--color-gray-600);
+  fill: currentColor;
+}
+
+.edit-icon:hover {
+  color: var(--color-brand);
 }
 
 /* Error page */

diff --git a/app/templates/components/guides-article.hbs b/app/templates/components/guides-article.hbs
@@ -30,7 +30,8 @@
           class='edit-page'
           rel='noopener'
         >
-          <img class='edit-icon' src='/images/pen.svg' alt='Edit pencil' />
+          {{!-- ! Font Awesome Free 6.2.0 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License) Copyright 2022 Fonticons, Inc. --}}
+          <svg class="edit-icon" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"><path d="M362.7 19.3L314.3 67.7 444.3 197.7l48.4-48.4c25-25 25-65.5 0-90.5L453.3 19.3c-25-25-65.5-25-90.5 0zm-71 71L58.6 323.5c-10.4 10.4-18 23.3-22.2 37.4L1 481.2C-1.5 489.7 .8 498.8 7 505s15.3 8.5 23.7 6.1l120.3-35.4c14.1-4.2 27-11.8 37.4-22.2L421.7 220.3 291.7 90.3z"/></svg>
         </a>
       {{/if}}
     </div>

diff --git a/public/images/pen.svg b/public/images/pen.svg
diff --git a/tests/dummy/config/environment.js b/tests/dummy/config/environment.js
@@ -23,17 +23,18 @@ module.exports = function (environment) {
       // when it is created
     },
     'ember-meta': {
-      description: 'Ember Guidemaker Template'
+      description: 'Ember Guidemaker Template',
     },
 
     guidemaker: {
-      title: 'Ember Guidemaker Template'
+      title: 'Ember Guidemaker Template',
+      sourceRepo: 'https://github.com/ember-learn/guidemaker-ember-template',
     },
 
     algolia: {
       algoliaId: 'FAKEKEY',
       algoliaKey: 'alsofake',
-      indexName: 'ember-guides'
+      indexName: 'ember-guides',
     },
 
     'ember-showdown-shiki': {
@@ -54,19 +55,19 @@ module.exports = function (environment) {
       ],
     },
 
-//     // you can comment out these lines if you want to test the info banner implementation
-//     survey: {
-//       content: `Take the [Ember Community Survey](https://emberjs.com/ember-community-survey-2019/)`
-//     },
+    //     // you can comment out these lines if you want to test the info banner implementation
+    //     survey: {
+    //       content: `Take the [Ember Community Survey](https://emberjs.com/ember-community-survey-2019/)`
+    //     },
 
-//     infoBanner: {
-//       content: `Thanks for taking the Octane preview for a test drive! Visit
-// <a href="https://emberjs.com" target="_blank" rel="noopener">thingy</a>
-// for more info and ways you can help out.
-// These preview guides URLs are subject to change, so point your bookmarks at that landing page.
-// If you are looking for the latest stable release of Ember, please instead visit
-// <a href="https://guides.emberjs.com" target="_blank" rel="noopener">guides.emberjs.com</a>.`
-//     },
+    //     infoBanner: {
+    //       content: `Thanks for taking the Octane preview for a test drive! Visit
+    // <a href="https://emberjs.com" target="_blank" rel="noopener">thingy</a>
+    // for more info and ways you can help out.
+    // These preview guides URLs are subject to change, so point your bookmarks at that landing page.
+    // If you are looking for the latest stable release of Ember, please instead visit
+    // <a href="https://guides.emberjs.com" target="_blank" rel="noopener">guides.emberjs.com</a>.`
+    //     },
 
     runPercyTest: process.env.RUN_PERCY_TESTS,
   };
@@ -91,7 +92,7 @@ module.exports = function (environment) {
     ENV.APP.autoboot = false;
 
     ENV['ember-tether'] = {
-      bodyElementId: 'ember-testing'
+      bodyElementId: 'ember-testing',
     };
   }