Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move @glimmer/component and @glimmer/tracking in dependencies #939

Conversation

ndekeister-us
Copy link
Contributor

@ndekeister-us ndekeister-us commented Sep 17, 2021

As @glimmer/component and @glimmer/tracking are now used in the addon directory via this commit -> https://github.com/ember-learn/ember-cli-addon-docs/pull/934/files#diff-59d3e78aa5dff5b8d7cdf515b80e1900e1a9fc0440bb3f64a1eb98aa62af2277R1-R2

They need to be moved in dependencies, otherwise we will have this error when using v4 of this repo in an addon/app not having, for example, @glimmer/component in his devDeps / deps ->

$ ember build --environment=production
Environment: production
cleaning up...
Build Error (WebpackBundler)

ember-cli-addon-docs tried to import "@glimmer/component" in "ember-cli-addon-docs/components/docs-hero/index.js" but the package was not resolvable from /Users/nathanaeldek/Projects/ember/ember-exam/node_modules/ember-cli-addon-docs

@ndekeister-us ndekeister-us changed the title fix: move @glimmer/component in dependencies fix: move @glimmer/component and @glimmer/tracking in dependencies Sep 17, 2021
@ndekeister-us ndekeister-us marked this pull request as ready for review September 17, 2021 11:50
@ndekeister-us
Copy link
Contributor Author

ping @rwwagner90, it should not be blocking for a lot of projects because i guess that, now, most Ember apps use @glimmer/component or @glimmer/tracking but for some (like ember-exam) it "blocks" the update to ember-cli-addon-docs@4

@RobbieTheWagner
Copy link
Member

Thanks @ndekeister-us!

@RobbieTheWagner RobbieTheWagner merged commit ae9edf1 into ember-learn:master Sep 17, 2021
@ndekeister-us ndekeister-us deleted the fix/glimmer-component_dependencies branch September 17, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants