Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix array helper clobbering built in helper #452

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

kturney
Copy link
Contributor

@kturney kturney commented Jan 30, 2020

The version of ember-composable-helpers currently being used provides an array helper.
ember@next has started erroring when it encounters built in helpers being clobbered.

ember-composable-helpers@3 has removed the array helper and upgraded to octane.
As an alternative to the commit, we could try to get a new version of ember-composable-helpers@2 cut that excludes the array helper for ember <= 3.8.

@kturney
Copy link
Contributor Author

kturney commented Jan 30, 2020

Additionally, I made an attempt at tracking down the timeout in test component page index works.
For some reason the click on the 'Internal' toggle is causing both the internal toggle and the private toggle to be checked (but also weirdly doesn't trigger a change event on the private checkbox.).
So when the 'private' toggle is clicked the checkbox is set to checked=false, so when we update in x-component the value doesn't actually change (setPrivate already equals false and is set to false).
If an additional private toggle click is placed after the existing private toggle click, the test passes.

@aklkv
Copy link

aklkv commented Mar 23, 2020

Any update on this!

@RobbieTheWagner
Copy link
Member

@kturney can you please rebase this off of master? Need to see if we can get Travis to run.

The version of ember-composable-helpers currently being used provides an array helper.
ember@next has started erroring when it encounters built in helpers being clobbered.

ember-composable-helpers@3 has removed the array helper and upgraded to octane.
As an alternative to the commit, we could try to get a new version of ember-composable-helpers@2 cut that excludes the array helper for ember <= 3.8.
@kturney kturney force-pushed the fix-ember-next-tests branch from 06d3ffa to b553632 Compare March 23, 2020 16:21
@kturney
Copy link
Contributor Author

kturney commented Mar 23, 2020

Hi @rwwagner90, I've rebased this PR on master.

I've also rebased #451 and #450 if you have any time to look at those.

@RobbieTheWagner
Copy link
Member

@kturney thanks! Looks like we have the issue with Ember and Babel now. I know that's fixed in latest Ember releases, but might take a bit to get Travis totally fixed here.

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's currently impossible to get tests running without this, so going to go ahead and merge.

@RobbieTheWagner RobbieTheWagner merged commit eb6b372 into ember-learn:master Mar 26, 2020
@kturney kturney deleted the fix-ember-next-tests branch March 26, 2020 16:34
@ming-codes
Copy link
Contributor

Can we cut a release for this?

@RobbieTheWagner
Copy link
Member

@ming-codes not until we get a passing build of the addon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants