-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix array helper clobbering built in helper #452
fix array helper clobbering built in helper #452
Conversation
Additionally, I made an attempt at tracking down the timeout in test |
Any update on this! |
@kturney can you please rebase this off of master? Need to see if we can get Travis to run. |
The version of ember-composable-helpers currently being used provides an array helper. ember@next has started erroring when it encounters built in helpers being clobbered. ember-composable-helpers@3 has removed the array helper and upgraded to octane. As an alternative to the commit, we could try to get a new version of ember-composable-helpers@2 cut that excludes the array helper for ember <= 3.8.
06d3ffa
to
b553632
Compare
@kturney thanks! Looks like we have the issue with Ember and Babel now. I know that's fixed in latest Ember releases, but might take a bit to get Travis totally fixed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's currently impossible to get tests running without this, so going to go ahead and merge.
Can we cut a release for this? |
@ming-codes not until we get a passing build of the addon. |
The version of ember-composable-helpers currently being used provides an array helper.
ember@next has started erroring when it encounters built in helpers being clobbered.
ember-composable-helpers@3 has removed the array helper and upgraded to octane.
As an alternative to the commit, we could try to get a new version of ember-composable-helpers@2 cut that excludes the array helper for ember <= 3.8.