update docs header #1128
update docs header #1128
Conversation
| }); | ||
| } | ||
| }); | ||
| matches.push(matchingText); |
There was a problem hiding this comment.
There is a bug somewhere around this logic of finding matches for the searched text.
It is however not related to this update, since the problem is already present on ec-addon-docs.
Basically, it presents very weird matches for the query you type. I suggest we address this separately.
| @@ -57,7 +57,6 @@ body > .ember-view { | |||
| @apply docs-flex; | |||
| @apply docs-flex-col; | |||
|
|
|||
| @apply docs-mt-1; | |||
There was a problem hiding this comment.
When you open the version selector, you could see the page jumping down a little bit (you can see that happening right now on the current docs website).
This was because opening the dropdown adds a new .ember-view div on the body, which gets targeted by this selector. Deleting the top margin didn't result in anything weird for me and fixed the problem.
There was a problem hiding this comment.
@miguelcobain Thanks for removing this! I noticed that in some of the documentation routes with lesser content, there's a similar but more pronounced white space jank due to the flex styles applied on .ember-view
What do you think about introducing a more specific class here instead of applying on the ember-view?
Updates
<DocsHeader/>component and its sub-components.