Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs hero docs #1123

Merged
merged 1 commit into from
Feb 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test-apps/new-addon/tests/dummy/app/templates/index.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{{docs-hero
logo='ember'
slimHeading='New'
strongHeading='Addon'
byline='A simple addon.'}}
<DocsHero
@logo="ember"
@slimHeading="New"
@strongHeading="Addon"
@byline="A simple addon."/>

# Home

Expand Down
15 changes: 7 additions & 8 deletions tests/dummy/app/templates/docs/components/docs-hero.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ The component has three arguments. By default, these arguments are pulled from y
- `prefix` and `heading` come from the `name` field
- `byline` comes from the `description` field

As long as these are present, you can just render `{{docs-hero}}` with no arguments:
As long as these are present, you can just render `<DocsHero/>` with no arguments:

<DocsDemo as |demo|>
<demo.example @name="docs-hero-1.hbs">
{{docs-hero}}
<DocsHero/>
</demo.example>

<demo.snippet @name="docs-hero-1.hbs"/>
Expand All @@ -21,12 +21,11 @@ You can also override any of the args if necessary:

<DocsDemo as |demo|>
<demo.example @name="docs-hero-2.hbs">
{{docs-hero
prefix="EmberData"
heading="Something"
byline="The best addon ever. Now playing in theaters."
class="some-custom-class"
}}
<DocsHero
@prefix="EmberData"
@heading="Something"
@byline="The best addon ever. Now playing in theaters."
class="some-custom-class"/>
</demo.example>

<demo.snippet @name="docs-hero-2.hbs"/>
Expand Down
4 changes: 2 additions & 2 deletions tests/dummy/app/templates/index.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{docs-hero}}
<DocsHero />

<div class="docs-container docs-md">
<section class="docs-max-w-md docs-mx-auto docs-pb-8">
Expand All @@ -13,4 +13,4 @@
</LinkTo>
</div>
</section>
</div>
</div>