Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update controllers syntax #1117

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

miguelcobain
Copy link
Collaborator

Not much here, but trying to update the various addon parts one at a time.
I removed the addon/controllers/docs/api/class.js controller, since I didn't see any usage of it.

@SergeAstapov
Copy link
Collaborator

test-apps/new-addon/tests/dummy/app/controllers/route-using-compile-markdown.js looks good!

would leave call about docs/api/class controller to @rwwagner90

@RobbieTheWagner
Copy link
Member

@miguelcobain I would think that controller would be used somewhere, but I don't know. Looks like to me it's the controller to automatically generated method names for the auto generated docs?

@miguelcobain
Copy link
Collaborator Author

@rwwagner90 a global search for methodParams yields no results in the whole repository.
Would that controller be used on the consuming app?

@RobbieTheWagner
Copy link
Member

@miguelcobain perhaps you are right. It could be a leftover thing.

@miguelcobain
Copy link
Collaborator Author

@rwwagner90 tried searching on ember observer for methodParams. No results that seem to use this. Same for docs/api/class, so nothing is importing the controller.

@RobbieTheWagner RobbieTheWagner merged commit 2f2b468 into ember-learn:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants