Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For EmberTimes No. 89: Add Octane Guides Quest Issue + Nested Anglebracket RFC #8

Merged
merged 4 commits into from
Mar 13, 2019
Merged

For EmberTimes No. 89: Add Octane Guides Quest Issue + Nested Anglebracket RFC #8

merged 4 commits into from
Mar 13, 2019

Conversation

jayjayjpg
Copy link
Contributor

What it does

Related Issue(s)

Sources

@jayjayjpg jayjayjpg requested a review from a team March 13, 2019 17:10
chrisrng
chrisrng approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@chrisrng chrisrng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

source/2019-03-15-the-ember-times-issue-89.md Outdated Show resolved Hide resolved
source/2019-03-15-the-ember-times-issue-89.md Outdated Show resolved Hide resolved
MinThaMie
MinThaMie approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@jayjayjpg jayjayjpg merged commit 835ac4b into ember-learn:blog/embertimes-89 Mar 13, 2019
@amyrlam amyrlam added the embertimes PR for an Ember Times issue label Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinThaMie MinThaMie MinThaMie approved these changes

@chrisrng chrisrng chrisrng approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jayjayjpg @chrisrng @MinThaMie @amyrlam