-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.21 Release Post #745
3.21 Release Post #745
Conversation
8860e6c
to
f7220c3
Compare
|
||
### Changes in Ember CLI 3.21 | ||
|
||
#### New Features (?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ember new --lang
support landed in ember-cli/ember-cli#9259
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweak ember-try configuration for addons:
- drop Ember 3.12 (existing addons should consider this a breaking change) Drop Ember 3.12 from default addon testing matrix. ember-cli/ember-cli#9310
- add Ember 3.20 Add Ember 3.20 LTS to ember-try configuration. ember-cli/ember-cli#9308
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I will make sure to mention these items.
|
||
### Changes in Ember Data 3.21 | ||
|
||
Ember Data 3.21 release saw a few improvements to documentation and continuous integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the changelog, I saw that ember-data#7228. I wasn't sure what the PR change did, however. If the change is important for developers to know, will you let me know how to explain it? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igorT @runspired If you have time, can you help me with answering this question?
24c5d32
to
f9a29b9
Compare
f9a29b9
to
8b351d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, left one suggestion (non-blocking), remove WIP from PR title before merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment. Not a blocker. Looks great, thank you for doing this!
|
||
Ember.js 3.21 is an incremental, backwards compatible release of Ember with bugfixes, performance improvements, and minor deprecations. | ||
|
||
#### New Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker at all, but it looks to me like we have typically added the number of features/deprecations in parens in the heading, even if it's zero. Maybe we decided to move away from this though?
#### New Features | |
#### New Features (0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I removed the numbers from the headings. If showing the numbers in parentheses was a convention, I'm okay with restoring the parentheses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, historically there has been a lot of controversy over the numbering in #core-meta (sometimes the # count was wrong, or the # didn't seem that helpful), seems good to get rid of it 👍 *but no strong opinion!
No description provided.