Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.21 Release Post #745

Merged
merged 9 commits into from
Sep 2, 2020
Merged

3.21 Release Post #745

merged 9 commits into from
Sep 2, 2020

Conversation

kennethlarsen
Copy link
Member

No description provided.

@ijlee2 ijlee2 marked this pull request as draft August 31, 2020 22:10

### Changes in Ember CLI 3.21

#### New Features (?)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ember new --lang support landed in ember-cli/ember-cli#9259

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweak ember-try configuration for addons:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will make sure to mention these items.


### Changes in Ember Data 3.21

Ember Data 3.21 release saw a few improvements to documentation and continuous integration.
Copy link
Member

@ijlee2 ijlee2 Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the changelog, I saw that ember-data#7228. I wasn't sure what the PR change did, however. If the change is important for developers to know, will you let me know how to explain it? Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorT @runspired If you have time, can you help me with answering this question?

@ijlee2 ijlee2 force-pushed the release/3-21-release branch 2 times, most recently from 24c5d32 to f9a29b9 Compare September 1, 2020 01:17
@ijlee2 ijlee2 marked this pull request as ready for review September 1, 2020 01:22
@ijlee2 ijlee2 requested review from a team September 1, 2020 01:22
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left one suggestion (non-blocking), remove WIP from PR title before merge?

@ijlee2
Copy link
Member

ijlee2 commented Sep 1, 2020

@amyrlam Thanks for reviewing the post!

@jenweber and @mansona will work on publishing the blog post, along with a new version of the Ember Guides.

@ijlee2 ijlee2 changed the title WIP: 3.21 Release Post 3.21 Release Post Sep 1, 2020
Copy link
Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. Not a blocker. Looks great, thank you for doing this!


Ember.js 3.21 is an incremental, backwards compatible release of Ember with bugfixes, performance improvements, and minor deprecations.

#### New Features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker at all, but it looks to me like we have typically added the number of features/deprecations in parens in the heading, even if it's zero. Maybe we decided to move away from this though?

Suggested change
#### New Features
#### New Features (0)

Copy link
Member

@ijlee2 ijlee2 Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I removed the numbers from the headings. If showing the numbers in parentheses was a convention, I'm okay with restoring the parentheses.

Copy link
Member

@amyrlam amyrlam Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, historically there has been a lot of controversy over the numbering in #core-meta (sometimes the # count was wrong, or the # didn't seem that helpful), seems good to get rid of it 👍 *but no strong opinion!

@ijlee2 ijlee2 merged commit a7f9073 into master Sep 2, 2020
@ijlee2 ijlee2 deleted the release/3-21-release branch September 2, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants