Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add writeup on in-element and named blocks #656

Merged
merged 7 commits into from
May 23, 2020

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented May 22, 2020

@chancancode I took a stab at this but if you want to flesh out or edit anything, please feel free to commit directly to the branch!

Also, I know you mentioned hm_krystam, but couldn't find that handle on GitHub, if you want to add that?

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label May 22, 2020
@amyrlam amyrlam requested a review from a team May 22, 2020 03:48
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for covering both features! Looking forward to learn more about {{in-element}} myself!

@ijlee2
Copy link
Member

ijlee2 commented May 22, 2020

Amy, it looks like Godfrey gave you Krystan's Twitter handle. Here is their GitHub handle: https://github.com/gitKrystan

@amyrlam
Copy link
Member Author

amyrlam commented May 22, 2020

@ijlee2 thanks for the handle

to be honest, i'm not sure what @chancancode wanted written up re: krystan - godfrey, if you have any edits let me know!

@amyrlam
Copy link
Member Author

amyrlam commented May 22, 2020

talked to godfrey on discord!

@amyrlam amyrlam merged commit 1173018 into blog/embertimes-149 May 23, 2020
@amyrlam amyrlam deleted the amy/chancancode-updates branch May 23, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants