Added a section on Dependency Lint RFC for issue #92 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjayjpg
reviewed
Apr 4, 2019
There was a problem hiding this comment.
This reads great! ✨ I left one more small suggestion and I'm wondering if you can also add a small teaser sentence to the intro describing your section shortly (e.g. right after the Read about the benefits of **volunteering at a tech conference** at the top of the blog post)? Otherwise this looks good to go 🚀
|
|
||
| This lint helps us detect early if our addons rely on the same package but use different versions. In such cases, Ember CLI merges all versions into one. This can cause our app to behave unexpectedly and become hard to debug. 😨😰😱 | ||
|
|
||
| You can learn about `ember-cli-dependency-lint` addon and how to resolve dependency conflicts at [https://github.com/salsify/ember-cli-dependency-lint](https://github.com/salsify/ember-cli-dependency-lint). |
There was a problem hiding this comment.
I think it would be really cool to mention the RFC a last time with a call-to-action linking to it. E.g.
Suggested change
| You can learn about `ember-cli-dependency-lint` addon and how to resolve dependency conflicts at [https://github.com/salsify/ember-cli-dependency-lint](https://github.com/salsify/ember-cli-dependency-lint). | |
| You can learn about `ember-cli-dependency-lint` addon and how to resolve dependency conflicts at [https://github.com/salsify/ember-cli-dependency-lint](https://github.com/salsify/ember-cli-dependency-lint) and be sure to leave your comments on [the current proposal to include it by default](https://github.com/emberjs/rfcs/pull/464). |
What do you think?
There was a problem hiding this comment.
@jessica-jordan I made changes based on your suggestions. Thanks again!
amyrlam
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
I added a summary of RFC 464 (dependency lint) for issue 92.
Related Issue(s)
Adds to pull request #46.