Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Singleton Record Data RFC #41

Merged
merged 4 commits into from
Mar 29, 2019
Merged

Adds Singleton Record Data RFC #41

merged 4 commits into from
Mar 29, 2019

Conversation

jaredgalanis
Copy link
Member

No description provided.

jayjayjpg
jayjayjpg reviewed Mar 29, 2019
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I left two more small suggestions - let me know what you think! Otherwise this should be good to go after a rebase 👍

source/2019-03-30-the-ember-times-issue-91.md Outdated Show resolved Hide resolved
source/2019-03-30-the-ember-times-issue-91.md Outdated Show resolved Hide resolved
@jaredgalanis jaredgalanis requested a review from jayjayjpg March 29, 2019 17:34
jayjayjpg
jayjayjpg approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! Thank you for another ✨ writeup this week!

@jayjayjpg jayjayjpg merged commit 6cb812b into blog/embertimes-91 Mar 29, 2019
@amyrlam amyrlam added the embertimes PR for an Ember Times issue label Apr 2, 2019
@amyrlam amyrlam deleted the add-singleton-record-data-rfc branch May 1, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredgalanis @jayjayjpg @amyrlam