Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog(embertimes124): 400 releases of emberjs repo #349

Merged
merged 2 commits into from
Nov 15, 2019
Merged

blog(embertimes124): 400 releases of emberjs repo #349

merged 2 commits into from
Nov 15, 2019

Conversation

chrisrng
Copy link
Member

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Nov 15, 2019
jayjayjpg
jayjayjpg approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I left one more small suggestion, feel free to take it or leave as you prefer and thank you for another ✨ writeup this week!

@chrisrng chrisrng merged commit 1725853 into blog/embertimes-124 Nov 15, 2019
@chrisrng chrisrng deleted the chrisrng-patch-1 branch November 15, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisrng @jayjayjpg