Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember Release blog post v4.5 #1162

Merged
merged 19 commits into from
Jul 13, 2022
Merged

Ember Release blog post v4.5 #1162

merged 19 commits into from
Jul 13, 2022

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Jun 16, 2022

Content to write:

  • emberjs
  • data - reflecting v4.4
  • ember-cli

🐛 fixes

ember-cli/ember-cli#9760 Add timeout-minutes to GitHub CI jobs in app and addon blueprints @mansona 🐛
ember-cli/ember-cli#9785 Generate correct directory name in README.md and CONTRIBUTING.md files @bertdeblock
ember-cli/ember-cli#9857 Use createBuilder instead of deprecated buildOutput in test suite @geneukum
ember-cli/ember-cli#9919 Clean up ember-addon object in package file when destroying an in-repo addon @bertdeblock

deprecations

ember-cli/ember-cli#9823 [RFC 801] Deprecate blacklist and whitelist build options @bertdeblock
ember-cli/ember-cli#9906 Drop support for Node v12 @bertdeblock not a deprecation per se but 🤷
ember-cli/ember-cli#9909 Deprecate support for ember-cli-jshint @bertdeblock
ember-cli/ember-cli#9890 Make sure addons are discovered only once @wagenet
ember-cli/ember-cli#9898 Remove deprecated addonJsFiles method on addon model @bertdeblock unclear if this should be included since it's not a new deprecation but a removal of a deprecated method

features/misc

ember-cli/ember-cli#9825 Remove ember-export-application-global addon from app blueprint @bertdeblock
ember-cli/ember-cli#9848 Update ember-cli-dependency-checker to v3.3.1 @gnclmorais
ember-cli/ember-cli#9770 Include the addon’s name in the warning when a core command is overridden @davecombs

not sure we need to cover

ember-cli/ember-cli#9777 [DOC] Add bower note @jenweber
ember-cli/ember-cli#9778 Prune lodash dependencies @locks
ember-cli/ember-cli#9805 Add Node v16 to Node Support docs @bertdeblock
ember-cli/ember-cli#9858 Remove EXTEND_PROTOTYPES object in the app's config/environment.js file @bertdeblock
ember-cli/ember-cli#9859 Update git.io URLs @bertdeblock
ember-cli/ember-cli#9860 Add inline comment RE: runningTests variable @bertdeblock
ember-cli/ember-cli#9886 Remove deletion of @ember/jquery in addon blueprint @bertdeblock
ember-cli/ember-cli#9914 Temporarily skip failing ember new test for npm versions <= v6.0.0 @bertdeblock
ember-cli/ember-cli#9900 Remove unused CLI error class @bertdeblock
ember-cli/ember-cli#9917 update beta deps @kellyselden

Reviewed for accuracy:

  • emberjs
  • data
  • ember-cli

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for ember-blog ready!

Name Link
🔨 Latest commit 9e4f0d9
🔍 Latest deploy log https://app.netlify.com/sites/ember-blog/deploys/62cf2e5ca0ce5d0008531810
😎 Deploy Preview https://deploy-preview-1162--ember-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bertdeblock
Copy link
Contributor

I think for Ember CLI, it might be worth mentioning that support for Node v12 has been dropped?

@chriskrycho
Copy link
Contributor

chriskrycho commented Jun 16, 2022

Likely #emberjs/ember.js#20054 though we need to make a call on it b/c we have not yet updated guides or API docs or anything.

@chriskrycho
Copy link
Contributor

Note: if we include that, I have material from an internal update about that (using the polyfill) which we can reuse.

@jenweber
Copy link
Contributor Author

@bertdeblock got it, thanks for the note! I will add this.

@chriskrycho I pulled some minimal info from the RFC, in case you want to focus on the Guides. I put a placeholder for where we can link to the docs.

@chriskrycho
Copy link
Contributor

Yeah, let's tentatively plan to do a minimal bit from the RFC for this, with a link to the blog post I will put up a draft of tomorrow to go with the release notes!

@jenweber jenweber requested a review from a team June 17, 2022 01:47
@jenweber
Copy link
Contributor Author

@chriskrycho @cafreeman @NullVoxPopuli I added some info to this upcoming release blog post about RFCs you were involved in. Could you review the "new ember features" section for accuracy? I also want to make sure I capture the spirit/vision of the work. Thank you!

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this ready to go out! I’ve made two suggested tweaks to the blog post, and I’ll have the plain-functions-as-helpers blog post up next week. 😄

content/ember-4-5-released.md Outdated Show resolved Hide resolved
content/ember-4-5-released.md Outdated Show resolved Hide resolved
content/ember-4-5-released.md Outdated Show resolved Hide resolved
content/ember-4-5-released.md Outdated Show resolved Hide resolved
content/ember-4-5-released.md Outdated Show resolved Hide resolved
Thank you Chris Krycho!

Co-authored-by: Chris Krycho <[email protected]>
@jenweber
Copy link
Contributor Author

jenweber commented Jul 9, 2022

Thank you @chriskrycho for the edits, especially the improved framing of renderSettled.

@jenweber jenweber requested review from chriskrycho and a team July 11, 2022 22:04
@jenweber
Copy link
Contributor Author

@bertdeblock if you would like to review the CLI section, feedback is welcome! I saw you were the author of a bunch of CLI PRs.


### Changes in Ember CLI 4.5

This Ember CLI release drops support for Node 12. Node 12 reached "end of life"status (it no longer receives security updates) in April 2022.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This Ember CLI release drops support for Node 12. Node 12 reached "end of life"status (it no longer receives security updates) in April 2022.
This Ember CLI release drops support for Node 12. Node 12 reached "end of life" status (it no longer receives security updates) in April 2022.

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two further tweaks here.

content/ember-4-5-released.md Outdated Show resolved Hide resolved
content/ember-4-5-released.md Outdated Show resolved Hide resolved
Copy link
Contributor

@wycats wycats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jenweber jenweber merged commit be41ce8 into main Jul 13, 2022
@jenweber jenweber deleted the release-4.5 branch July 13, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants