Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amy writeups #1033

Merged
merged 3 commits into from
Sep 11, 2021
Merged

Amy writeups #1033

merged 3 commits into from
Sep 11, 2021

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented Sep 11, 2021

Ember Times review template

  • Add your name to top and bottom
  • Put emoji in writeup title
  • Add a short blurb (could be the title) to the beginning
  • Link to external article/repo/etc in paragraph/body text, not just the writeup title (link in writeup title is optional now)
  • Add the contributor in the post in format "FirstName LastName (@githubusername)" linked to their GitHub account
  • Check that all links work

What it does

Related Issue(s)

Sources

@amyrlam amyrlam requested a review from a team as a code owner September 11, 2021 02:53
@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Sep 11, 2021
@amyrlam amyrlam changed the base branch from main to blog/embertimes-188 September 11, 2021 02:53
@amyrlam amyrlam changed the title Amy/embertimes 188 Amy writeups Sep 11, 2021
@amyrlam amyrlam merged commit 05d449e into blog/embertimes-188 Sep 11, 2021
@amyrlam amyrlam deleted the amy/embertimes-188 branch September 11, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amyrlam