Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember-CLI 3.12 #419

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Ember-CLI 3.12 #419

merged 3 commits into from
Sep 13, 2019

Conversation

RobbieTheWagner
Copy link
Member

No description provided.

@RobbieTheWagner RobbieTheWagner requested a review from a team August 17, 2019 12:26
@RobbieTheWagner RobbieTheWagner changed the title Ember 3.12 Ember-CLI 3.12 Aug 17, 2019
@acorncom
Copy link
Member

@rwwagner90 looks like this is failing due to the lack of ember-fetch?

@RobbieTheWagner
Copy link
Member Author

@acorncom yeah, looks like it. Weird that it worked before though. Will take a look.

@RobbieTheWagner
Copy link
Member Author

Added ember-fetch and fixed conflicts. Hopefully things work now!

@RobbieTheWagner
Copy link
Member Author

@acorncom looks like this is passing now. Mind reviewing?

@locks locks merged commit 08e56ef into master Sep 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the ember-3.12 branch September 13, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivakumar-kailasam sivakumar-kailasam sivakumar-kailasam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RobbieTheWagner @acorncom @sivakumar-kailasam @locks