-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize rehydration serialization from glimmer #580
Changes from 4 commits
0b884c1
b3d2589
725aedb
91c4f97
6bbffd3
d896108
0fceedc
dc53d0d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ | |
"ember-cli-lodash-subset": "2.0.1", | ||
"ember-cli-preprocess-registry": "^3.1.0", | ||
"ember-cli-version-checker": "^2.1.0", | ||
"fastboot": "^1.1.3", | ||
"fastboot": "github:rondale-sc/fastboot#utilize-rehydration-serialization-from-glimmer", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just notating that this will need to be bumped to a release version before landing... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you change this to |
||
"fastboot-express-middleware": "^1.1.0", | ||
"fastboot-transform": "^0.1.2", | ||
"fs-extra": "^4.0.2", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
(function() { | ||
if (typeof FastBoot === 'undefined') { | ||
var current = document.getElementById('fastboot-body-start'); | ||
|
||
if ( | ||
current && | ||
typeof Ember.ViewUtils.isSerializationFirstNode === 'function' && | ||
Ember.ViewUtils.isSerializationFirstNode(current.nextSibling) | ||
) { | ||
Ember.ApplicationInstance.reopen({ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this how we plan to do this long term? Do we have a plan to remove this reopen? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't we need to turn off this: https://github.com/ember-fastboot/ember-cli-fastboot/blob/master/app/instance-initializers/clear-double-boot.js ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The clear-double-boot checks to see if |
||
_bootSync: function(options) { | ||
if (options === undefined) { | ||
options = { | ||
_renderMode: 'rehydrate' | ||
}; | ||
} | ||
|
||
return this._super(options); | ||
} | ||
}); | ||
|
||
// Prevent clearRender by removing `fastboot-body-start` which is already | ||
// guarded for | ||
current.parentNode.removeChild(current); | ||
var end = document.getElementById('fastboot-body-end'); | ||
end.parentNode.removeChild(end); | ||
} | ||
} | ||
})(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to mention from which version it is available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! I just added a small blurb about fastboot / ember.js requirements to address this concern.