Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to TypeScript #498

Merged
merged 54 commits into from
Feb 28, 2023
Merged

Conversation

gitKrystan
Copy link
Collaborator

@gitKrystan gitKrystan commented Jan 19, 2023

This is a bit of a yak shave.

  1. This codemod currently does not support legacy decorators, but we have users stuck on Ember classic that use legacy decorators (specifically, decorators in object literals).
  2. The currently-used Flow parser does not support legacy decorators, necessitating a switch to the babel parser. I did a POC spike on switching to this parser, and while it does parse the legacy decorators, there is enough of a shift in the AST format that it causes many of the existing tests to fail. In my spike, I started fixing the code to make these tests pass, but without TypeScript + good AST types, I don't have 100% confidence I'm not breaking things, and working on it is a bit like this gif:

See also: gitKrystan#1, gitKrystan#2

@gitKrystan gitKrystan marked this pull request as ready for review January 24, 2023 00:27
@gitKrystan
Copy link
Collaborator Author

Approved by @wycats via Telegram

@gitKrystan gitKrystan merged commit 333fd31 into ember-codemods:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants