Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no-new-mixins rule documentation #655

Merged
merged 1 commit into from Feb 9, 2020
Merged

Update no-new-mixins rule documentation #655

merged 1 commit into from Feb 9, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 28, 2020

I think we should consider removing code examples from this rule in favor of linking to community curated examples. In the linked discourse thread I'm plugging using Ember Atlas because it fills this void nicely.
The examples showcase a functional style of programming that may not be relevant in various applications.

@bmish bmish changed the title flesh out mixin prohibition Update no-new-mixins rule documentation Jan 28, 2020
@bmish
Copy link
Member

bmish commented Jan 28, 2020

The discord link you're adding looks great. I do still think our rule documentation needs to contain at least a basic code example or two (feel free to update them), so that it can stand on its own. Otherwise, our rules become harder to understand when various links need to be pieced together just to get the basics.

@ghost
Copy link
Author

ghost commented Jan 28, 2020

@bmish makes sense! As I and team update our application I can add a few snippets from that process so they are self contained on this page.

@bmish bmish merged commit 1167557 into ember-cli:master Feb 9, 2020
@ghost ghost deleted the cleanup-mixin-rule branch February 10, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants