Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ember-eslint-parser to 0.2.3 #2045

Merged
merged 6 commits into from
Dec 29, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Dec 28, 2023

@bmish bmish added the bug label Dec 28, 2023
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review December 28, 2023 22:47
@NullVoxPopuli NullVoxPopuli marked this pull request as draft December 28, 2023 23:02
@patricklx
Copy link
Contributor

fixed in ember-tooling/ember-eslint-parser#15 :)

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review December 29, 2023 15:12
@NullVoxPopuli NullVoxPopuli changed the title fix template-no-let-reference Upgrade ember-eslint-parser Dec 29, 2023
@NullVoxPopuli NullVoxPopuli marked this pull request as draft December 29, 2023 15:30
@NullVoxPopuli
Copy link
Contributor Author

Found another issue with the parser 😅

Work on that here: ember-tooling/ember-eslint-parser#18

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review December 29, 2023 18:15
@NullVoxPopuli
Copy link
Contributor Author

@bmish can we do al alpha.5 after this PR?
Something is messed up with my deps, and I think installing from proper npm would help a smidge <3

@bmish
Copy link
Member

bmish commented Dec 29, 2023

Yes although I think it's pretty important that it is tested locally first (e.g. yarn link or whatever is needed) before we release it.

@NullVoxPopuli
Copy link
Contributor Author

oh I found the issue, I had pinned @glimmer/syntax to an older version in overrides, and I can't be doing that 😅

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Dec 29, 2023

ooo, I found an issue that's not even related to gts

TypeError: Cannot read properties of undefined (reading 'isRoute')
Occurred while linting <repo>/apps/repl/tests/application/output-demos-test.ts:69
Rule: "ember/no-deprecated-router-transition-methods"

image

is this a new rule? hm. I wonder why it's active in my tests.

it is!!

https://github.com/ember-cli/eslint-plugin-ember/blob/master/CHANGELOG.md#v1200-alpha0-2023-11-04

ok, so I think we're good to move forward with this PR.

The above issue here warrants a separate PR.
That PR is here: #2046

@NullVoxPopuli NullVoxPopuli added the dependencies Pull requests that update a dependency file label Dec 29, 2023
@NullVoxPopuli
Copy link
Contributor Author

note, this PR is just a dep bump

@NullVoxPopuli NullVoxPopuli merged commit b2b956f into master Dec 29, 2023
8 checks passed
@NullVoxPopuli NullVoxPopuli deleted the failing-test-for-template-no-let-reference branch December 29, 2023 20:06
@bmish bmish changed the title Upgrade ember-eslint-parser Upgrade ember-eslint-parser dependency to 0.2.3 Dec 29, 2023
@bmish bmish changed the title Upgrade ember-eslint-parser dependency to 0.2.3 Bump ember-eslint-parser to 0.2.3 Jan 1, 2024
@bmish bmish changed the title Bump ember-eslint-parser to 0.2.3 Bump ember-eslint-parser to 0.2.3 Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants