Add volta in package.json #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersions of the specified tools
2 tasks
bmish
reviewed
Dec 21, 2023
package.json
Outdated
| @@ -132,6 +132,10 @@ | |||
| "engines": { | |||
| "node": "18.* || 20.* || >= 21" | |||
| }, | |||
| "volta": { | |||
| "node": "18.19.0", | |||
There was a problem hiding this comment.
I suppose, but convention has been to keep local environment on min-supported so you don't accidentally use a feature that's not in your min-supported node.
(exception being libraries that don't need node at all, such as browser-only libraries)
There was a problem hiding this comment.
We have CI tests for all of our supported Node versions. I would prefer to rely on those to catch issues.
bmish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to help folks using volta use the correct versions of the specified tools