Allow ember-data type registry imports in use-ember-data-rfc-395-imports rule
#2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you target the v11 branch instead of master? Then I can release this as a bug fix to v11, as v12 on master is still WIP. |
bmish
force-pushed
the
ember-data-type-registries
branch
from
e73069e to
ceccbe0
Compare
bmish
changed the title
use-ember-data-rfc-395-imports rule
Merged
bmish
added a commit
that referenced
this pull request
Dec 12, 2023
* Support ESLint flat config (#2020) * Allow ember-data type registry imports in `use-ember-data-rfc-395-imports` rule (#2027) * Allow ember-data type registry imports * fix lint --------- Co-authored-by: Bryan Mishkin <[email protected]> * fix lint * Release 11.12.0 * fix merge mistakes --------- Co-authored-by: Peter Wagenet <[email protected]>
|
@bmish whoops, sorry I missed this. Thanks for taking care of it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue raised by #1833, though we require the import to be directly from the registry module.