Add template-no-let-reference rule to recommended-gjs and recommended-gts configs
#1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 |
bmish
reviewed
Nov 5, 2023
| @@ -6,6 +6,7 @@ module.exports = { | |||
| description: 'disallow referencing let variables in \\<template\\>', | |||
| category: 'Ember Octane', | |||
| recommended: true, | |||
| recommended_for: 'gjs', | |||
There was a problem hiding this comment.
Can we follow the current pattern which is configName: true to indicate if the rule belongs to a config?
There was a problem hiding this comment.
You mean replace recommended_for with configName: 'gts'?
There was a problem hiding this comment.
Any examples for that property?
There was a problem hiding this comment.
No, we should use the config name as the property name, no shorthand:
recommendedGts: true
And then we can automatically transform camelCase to kebab-case when checking if a rule is enabled for a config.
patricklx
force-pushed
the
patch-6
branch
2 times, most recently
from
89f089b to
57a1e24
Compare
bmish
reviewed
Nov 6, 2023
bmish
approved these changes
Nov 6, 2023
bmish
changed the title
template-no-let-reference rule to recommended-gjs and recommended-gts configs
NullVoxPopuli
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove from
recommendedconfig.Follow-up to:
recommendedrule:template-no-let-reference#1977