Do not disable in production #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes things not disabled in production anymore, and removes old MU code.
RobbieTheWagner
changed the title
ijlee2
approved these changes
Jun 15, 2020
|
I'd like @rwjblue to give a once over before we merge! |
rwjblue
reviewed
Jun 16, 2020
| app.import('vendor/welcome-page.css'); | ||
| }, | ||
|
|
||
| config: function() { | ||
|
|
||
| config() { |
There was a problem hiding this comment.
We should remove this also, any MU support code should be released before the next major.
There was a problem hiding this comment.
I had initially removed all MU code, but @locks wanted me to remove those changes to make the changelog cleaner and do it in another PR.
|
The convo in #262 is current, and AFAICT the status is unchanged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes things not disabled in production anymore.
Closes #262