Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #3: remove actual version check and preserve resolutions #6

Merged
merged 2 commits into from
Apr 3, 2015

Conversation

habdelra
Copy link

@habdelra habdelra commented Apr 2, 2015

Fixes #3

So I included the suggestion that @rwjblue had, as well as I'm preserving the resolutions. Now in your scenario files you can optionally specify a resolutions object, like this:

module.exports = {
  scenarios: [
    {
      name: 'ember-release',
      dependencies: {
        "ember": "components/ember#release"
      },
      resolutions: {
        "ember": "release"
      }
    },
    {
      name: 'ember-beta',
      dependencies: {
        "ember": "components/ember#beta"
      },
      resolutions: {
        "ember": "beta"
      }
    },
    {
      name: 'ember-canary',
      dependencies: {
        "ember": "components/ember#canary"
      },
      resolutions: {
        "ember": "canary"
      }
    }
  ]
};

or if you are not using shims, you can specify something like this:

module.exports = {
  scenarios: [
    {
      name: 'ember-release',
      dependencies: {
        "ember": "ember#release"
      },
      resolutions: {
        "ember": "release"
      }
    },
    {
      name: 'ember-beta',
      dependencies: {
        "ember": "ember#beta"
      },
      resolutions: {
        "ember": "beta"
      }
    },
    {
      name: 'ember-canary',
      dependencies: {
        "ember": "ember#canary"
      },
      resolutions: {
        "ember": "canary"
      }
    }
  ]
};

I believe this should fix that problem that you had with the canary channel.

@habdelra habdelra force-pushed the master branch 4 times, most recently from fe0a126 to 9ead54f Compare April 2, 2015 03:58
kategengler added a commit that referenced this pull request Apr 3, 2015
fixes #3: remove actual version check and preserve resolutions
@kategengler kategengler merged commit bc2aba7 into ember-cli:master Apr 3, 2015
@rwjblue
Copy link
Member

rwjblue commented Apr 3, 2015

Awesome!

luxzeitlos pushed a commit to luxzeitlos/ember-try that referenced this pull request Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow testing of beta and canary versions.
3 participants