Handle additional yarn workspace definition formats
#463
Conversation
| if (fs.existsSync(path.join(this.cwd, this.nodeModulesBackupLocation))) { | ||
| restoreTasks.push(copy(path.join(this.cwd, this.nodeModulesBackupLocation), | ||
| path.join(this.cwd, this.nodeModules), { clobber: true })); | ||
| } |
There was a problem hiding this comment.
Yarn workspaces can hoist packages in such a way that a node_modules folder may never be created. This checks the existence of the directory before trying to restore it
| if (fs.existsSync(path.join(this.cwd, this.nodeModules))) { | ||
| backupTasks.push(copy(path.join(this.cwd, this.nodeModules), | ||
| path.join(this.cwd, this.nodeModulesBackupLocation), { clobber: true })); | ||
| } |
There was a problem hiding this comment.
Similar to above, but when backing up packages
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
+ Coverage 96.88% 96.91% +0.03%
==========================================
Files 17 17
Lines 577 584 +7
==========================================
+ Hits 559 566 +7
Misses 18 18
Continue to review full report at Codecov.
|
|
Is there anything else I need to do? Any information that's missing that I could provide? |
| let workspaceGlobs = packageJSON.workspaces | ||
|
|
||
| if (workspaceGlobs && workspaceGlobs.packages) { | ||
| workspaceGlobs = workspaceGlobs.packages | ||
| } |
There was a problem hiding this comment.
Can you tweak this to be specific about what we expect? I'm thinking of something like:
let workspaceGlobs = Array.isArray(packageJSON.workspaces) ? packageJSON.workspaces : packageJSON.workspaces.packages;There was a problem hiding this comment.
Sure! Ended up with
if (Array.isArray(packageJSON.workspaces)) {
workspaceGlobs = packageJSON.workspaces
}
if (packageJSON.workspaces && Array.isArray(packageJSON.workspaces.packages)) {
workspaceGlobs = packageJSON.workspaces.packages
}so it's specific about each case
rwjblue
changed the title
yarn workspace definition formats
|
Thank you @BarryThePenguin! |
|
No worries! The latest ember times talked about using mono-repos to manage large ember apps. It mentions ember-try at the end, so it was a good reminder! |
Yarn workspaces can have two different definitions
and
This PR adds support for the second definition