Add support for dev dependencies #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +47,12 @@ module.exports = CoreObject.extend({ | |||
| var pkgs = Object.keys(scenario.dependencies); | |||
|
|
|||
| pkgs.forEach(function(pkg){ | |||
| bowerJSON.dependencies[pkg] = scenario.dependencies[pkg]; | |||
| if (bowerJSON.devDependencies[pkg]) { | |||
| bowerJSON.devDependencies[pkg] = scenario.dependencies[pkg]; | |||
There was a problem hiding this comment.
wouldn't you want
scenario.devDependencies[pkg]There was a problem hiding this comment.
I think it's not worth the distinction in this case. But I can imagine this changes somewhere in the future. If it's preferred to distinct between dependencies and devDepencies i'll change it.
There was a problem hiding this comment.
I would keep them separated, so that a scenario can be expressed as follows:
{
name: 'ember-1.11',
dependencies: {
'ember': '~1.11.0'
},
devDependencies: {
'somePkg': '~99.99.1'
}
}
There was a problem hiding this comment.
@truenorth - Agreed.
@martndemus - Would you mind updating for that structure?
|
Now even with unit tests. |
|
👍 |
rwjblue
added a commit
that referenced
this pull request
Jul 22, 2015
Add support for dev dependencies
|
Thanks @martndemus! this is a nice addition to the addon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for overriding bower packages specified in
devDependencies.I should add (a) test(s).