Add yarn resolutions #259
Merged
Add yarn resolutions #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rwjblue
approved these changes
Jan 20, 2019
kategengler
approved these changes
Jan 20, 2019
This PR adds resolution support for ember-try configs that are using yarn. It uses the same merging strategy that the dependencies, devDependencies, and peerDependencies use.
ryanto
force-pushed
the
yarn-resolutions2
branch
from
94710c9 to
6a08b29
Compare
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 95.36% 95.37% +0.01%
==========================================
Files 17 17
Lines 539 541 +2
==========================================
+ Hits 514 516 +2
Misses 25 25
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 95.36% 95.37% +0.01%
==========================================
Files 17 17
Lines 539 541 +2
==========================================
+ Hits 514 516 +2
Misses 25 25
Continue to review full report at Codecov.
|
|
Ok great! I just rebased off master and everything is green. |
|
Thanks! |
cyril-sf
pushed a commit
to Addepar/ember-table
that referenced
this pull request
Mar 10, 2019
cyril-sf
pushed a commit
to Addepar/ember-table
that referenced
this pull request
Mar 10, 2019
cyril-sf
pushed a commit
to Addepar/ember-table
that referenced
this pull request
Mar 10, 2019
Upgrade ember-try to support `resolutions`. See ember-cli/ember-try#259
cyril-sf
pushed a commit
to Addepar/ember-table
that referenced
this pull request
Mar 13, 2019
Needs to update ember-try to support `resolutions` See ember-cli/ember-try#259
|
@ryanto Would you be willing to add some documentation for this to the README? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds resolution support for ember-try configs that are using yarn.
It uses the same merging strategy that the dependencies, devDependencies, and
peerDependencies use.