Move ember-cli-babel to a devDependency. #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addon does not leverage `addon` or `addon-test-support` trees, and therefore doesn't need to have `ember-cli-babel` as a runtime dep when included in other applications. `ember-cli-babel` here is only used for the internal testing dummy app...
|
Makes sense to me. I think I moved it to dependencies originally because it told me too when running tests against the dummy app :) |
kategengler
approved these changes
Apr 22, 2017
|
This came up because I'm trying to get a default [email protected] app to ship without requiring both babel@6 and babel@5. So I've been updating addons to babel@6 that we ship by default, in this case I just didn't think it mattered because I don't think it is being used... |
|
Confirmed locally (linked into an app), no warnings or deprecations are triggered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addon does not leverage
addonoraddon-test-supporttrees, and therefore doesn't need to haveember-cli-babelas a runtime dep when included in other applications.ember-cli-babelhere is only used for the internal testing dummy app...