Remove use of mockery
#1029
Merged
Remove use of mockery
#1029
+48
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
+ Coverage 95.44% 95.50% +0.06%
==========================================
Files 21 21
Lines 505 512 +7
==========================================
+ Hits 482 489 +7
Misses 23 23 ☔ View full report in Codecov by Sentry. |
bertdeblock
commented
Dec 17, 2024
|
|
||
| module.exports = run; | ||
|
|
||
| module.exports._originalRunFunction = originalRunFunction; |
There was a problem hiding this comment.
Not ideal though, to have these "private" exports, but since importing from ember-try is not really supported, this seemed okay for now.
kategengler
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mockeryproject is old, and archived.I also had some issues with it when converting the test suite to ES modules, so seemed easiest to just get rid of it, and use a more "vanilla" approach.