Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killing ember-try while it's running leaves bower.json modified #20

Closed
mike-north opened this issue Apr 17, 2015 · 4 comments
Closed

Killing ember-try while it's running leaves bower.json modified #20

mike-north opened this issue Apr 17, 2015 · 4 comments

Comments

@mike-north
Copy link
Member

Scenario

I have a hanging test, and I kill ember-try with ctrl-c. My bower.json is left in a state where my scenario is still applied

Suggestions

  1. We find a way to have ember-try clean up after its self upon teardown
  2. We add a command to ember-try, to easily restore the project's original bower.json
@rwjblue
Copy link
Member

rwjblue commented Apr 17, 2015

I think I prefer option 2, and try to detect the scenario (by seeing the old backup/lock file and restoring first).

@mike-north
Copy link
Member Author

After talking with @stefanpenner it sounds like any solution similar to option 1 would be difficult to accomplish in a robust and predictable way.

Another idea is to restore bower.json before the tests actually start running (i.e., immediately after bower install completes) but I'm not sure if there are any negative ramifications with this approach.

@kategengler
Copy link
Member

So for option 2, something like this? https://github.com/kategengler/ember-try#ember-tryreset

@rwjblue
Copy link
Member

rwjblue commented Apr 19, 2015

Hehe, yep!

luxzeitlos pushed a commit to luxzeitlos/ember-try that referenced this issue Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants