-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add back toc names for inspector #241
Conversation
a776d1d
to
b312367
Compare
src/babel-plugin.js
Outdated
) { | ||
let params = path.node.arguments; | ||
let assignment = path.parentPath.parentPath.node; | ||
let rootName = basename(state.filename).slice( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would propose to remove endings like: template
, component
, index
Cases:
my-table/template.gts
my-table/component.gts
my-table/index.gts
@patricklx I'm thinking about ways to integrate it to release pipeline to not miss it in future. |
c43cd17
to
c7f8272
Compare
c7f8272
to
7b80adb
Compare
take the paths from app root, not project root
@lifeart what about this? |
@patricklx looks good for me! |
Who can merge? @NullVoxPopuli ? |
tests-babel/transform.test.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for classic app and addon paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, for my confidence, however, i'd like a couple more tests for our various scenarios
- classic app
- pods app
- classic addon
- app name is doubled up in the path instead of using the 'app' folder (broccoli thing)
Mostly it doesn't matter what path is in there. For classic I'm depending in the project.root, parent.root to slice that off the filename. |
Can you push again real quick? Ci was disabled |
this was removed in v4
it was there until v3.
https://github.com/ember-template-imports/ember-template-imports/blob/v3.4.2/src/babel-plugin.js#L42
with this change: