Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back toc names for inspector #241

Merged
merged 12 commits into from
Sep 22, 2024

Conversation

patricklx
Copy link
Contributor

@patricklx patricklx commented Jul 8, 2024

@patricklx patricklx force-pushed the add-back-toc-name branch from a776d1d to b312367 Compare July 8, 2024 10:34
src/babel-plugin.js Outdated Show resolved Hide resolved
) {
let params = path.node.arguments;
let assignment = path.parentPath.parentPath.node;
let rootName = basename(state.filename).slice(
Copy link

@lifeart lifeart Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would propose to remove endings like: template, component, index
Cases:

my-table/template.gts
my-table/component.gts
my-table/index.gts

@lifeart
Copy link

lifeart commented Jul 8, 2024

@patricklx I'm thinking about ways to integrate it to release pipeline to not miss it in future.
We may add https://www.npmjs.com/package/babel-plugin-tester to test this babel plugin as part of test command
Here is sample: https://github.com/babel-utils/babel-plugin-tester/tree/master/test/examples (tldr - we need to create folder with 3 files, input, output, babel config - and plugin will be executed over input and compared with output)

@patricklx patricklx force-pushed the add-back-toc-name branch from c43cd17 to c7f8272 Compare July 8, 2024 11:03
@patricklx patricklx force-pushed the add-back-toc-name branch from c7f8272 to 7b80adb Compare July 8, 2024 11:06
@patricklx patricklx requested a review from lifeart August 22, 2024 09:53
@patricklx
Copy link
Contributor Author

@lifeart what about this?

@lifeart
Copy link

lifeart commented Sep 21, 2024

@patricklx looks good for me!

@patricklx
Copy link
Contributor Author

Who can merge? @NullVoxPopuli ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for classic app and addon paths?

Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, for my confidence, however, i'd like a couple more tests for our various scenarios

  • classic app
  • pods app
  • classic addon
  • app name is doubled up in the path instead of using the 'app' folder (broccoli thing)

@patricklx
Copy link
Contributor Author

Mostly it doesn't matter what path is in there.
Here I'm also trying to fix the full path beeing added to the transform. That only happens under embroider.

For classic I'm depending in the project.root, parent.root to slice that off the filename.

@NullVoxPopuli
Copy link
Collaborator

Can you push again real quick? Ci was disabled

@patricklx patricklx closed this Sep 22, 2024
@patricklx patricklx reopened this Sep 22, 2024
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Sep 22, 2024
@NullVoxPopuli NullVoxPopuli merged commit 646fdf8 into ember-cli:master Sep 22, 2024
16 checks passed
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants