Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update per-module markdown table in README. #50

Merged
merged 9 commits into from
Apr 23, 2018

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 23, 2018

Also fixes a few issues with generating the table (likely from the data
format changes).

README.md Outdated
| `Ember.warn` | `import { warn } from '@ember/debug';` |
| Before | After |
| --- | --- |
| `Ember.$` | `import { default } from 'jquery';` |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, will fix

| `Ember.Application` | `import Application from '@ember/application';` |
| `Ember.ApplicationInstance` | `import ApplicationInstance from '@ember/application/instance';` |
| `Ember.Array` | `import EmberArray from '@ember/array';` |
| `Ember.ArrayProxy` | `import ArrayProxy from '@ember/array/proxy';` |
| `Ember.AutoLocation` | `import AutoLocation from '@ember/routing/auto-location';` |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were unsorted before, now they are sorted by the global name.

@rwjblue rwjblue merged commit b155da5 into ember-cli:master Apr 23, 2018
@rwjblue rwjblue deleted the fixup-scripts branch April 23, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant