Use buildHelper as localName for Ember.Helper.helper #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the ember-modules-codemod to generate transformed helper files
that `import { helper as buildHelper }`. This brings it
into alignment with the ember-module-migrator's output.
The related change in the module migrator is here: ember-codemods/ember-module-migrator#69
Importing the helper as buildHelper allows the module migrator to `export const helper = buildHelper(...`,
which is necessary to avoid an issue where incorrect `export const helper = helper(...` code was being generated.
The issue that motived the helper->buildHelper change is: emberjs/ember.js#16361 (comment)
rwjblue
approved these changes
Apr 2, 2018
|
Thank you! |
|
no problem! I'll keep an eye on this and will issue a corresponding update PR to the codemod repo when this package gets a new release. (I'm happy to do the release myself if you want to add me) |
bantic
added a commit
to bantic/ember-rfc176-data
that referenced
this pull request
Apr 2, 2018
This was changed in ember-cli#45 but I forgot to update the README too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the ember-modules-codemod to generate transformed helper files
that
import { helper as buildHelper }. This brings itinto alignment with the ember-module-migrator's output.
The related change in the module migrator is here: ember-codemods/ember-module-migrator#69
Importing the helper as buildHelper allows the module migrator to
export const helper = buildHelper(...,which is necessary to avoid an issue where incorrect
export const helper = helper(...code was being generated.The issue that motived the helper->buildHelper change is: emberjs/ember.js#16361 (comment)