Support mu namespaced in lookup string in glimmer wrapper #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolver.resolve now takes a third argument `rawString` which is the
string used at the invocation site of the lookup. For example for:
```
{{ember-power-select::option}}
```
The lookup should be:
```
resolver.resolve('template:component/', null, 'ember-power-select::option')
``
And for a service example:
```
Ember.service.inject('auth-addon::main-service')
```
The lookup would be:
```
resolver.resolve('service', null, 'auth-addon::main-service')
```
Refs: ember-cli#214
Refs: emberjs/ember.js#15350 (comment)
resolver.resolve can accept a namespace denoted by a double colon in the first argument, for example:
- `service:other-namespace::i18n`
- `template:components/other-namespace::my-component`
For example for:
```
{{ember-power-select::option}}
```
The lookup should be:
```
resolver.resolve('template:component/ember-power-select::option’)
``
And for a service example:
```
Ember.service.inject('auth-addon::main-service')
```
The lookup would be:
```
resolver.resolve('service:auth-addon::main-service’)
```
Refs: ember-cli#214
Refs: emberjs/ember.js#15350 (comment)
iezer
force-pushed
the
namespace-in-lookup-string
branch
from
6fbfa33 to
871065f
Compare
|
This may be related with what I'm seeing. I am making a port of http://ember-basic-dropdown.com to the module unification and when I try to resolve the route I probably can come up with a reproduction if needed, but seems you are already aware of the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports module unification namespaces by passing them in the lookup string. This an alternative to #215. Doing it this way reduces the number of changes required in ember.js and here as well.
A new version of glimmer-resolver has to be released in order for these tests to pass. Issue: glimmerjs/glimmer-resolver#24
Examples:
resolver.resolve('template:components/other-namespace::my-component')it will passtemplate:/other-namespace/components/my-componentto the glimmer resolver.resolver.resolve('service:/other-namespace/services/i18n')it will passservice:other-namespace::i18nto the glimmer resolver.See emberjs/ember.js#15967 for results of end-to-end test.
Related PRs: