Setup TypeScript Infra #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guess I should close me pr |
|
I will be borrowing basically everything from that pr! Thank you @knownasilya 🙏 |
NullVoxPopuli
force-pushed
the
add-types
branch
from
511f8dd to
b570baf
Compare
Woo type errors, deprecations! Add test-types project Rename files Upgrade and install updated lint config / dependencies Add test script to test-types Update more deps
NullVoxPopuli
force-pushed
the
add-types
branch
2 times, most recently
from
8a7e6be to
f0084f4
Compare
NullVoxPopuli
force-pushed
the
add-types
branch
from
f0084f4 to
77fd10d
Compare
…resolve correctly in monorepos when also installed as a devDependency, so we need to use the injected feature to remove the devDependencies for the consumed version of the addon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As ember has first-class TypeScript support out of the box (almost), we need to to have all core addons also support that.
Like always, consumers don't need to use TypeScript, but our library code using TypeScript will provide better intellisense for both JavaScript and TypeScript users.
Incidentally, achieving more alignment with the TS-v2-addon blueprint, we gain support for Glint-using projects.
This work lays foundation for the work of #246 so that the diff can be smaller.
Main changes:
--typescriptusing v2 addon blueprint