Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setup for releasing via tags #261

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Add a setup for releasing via tags #261

merged 4 commits into from
Aug 16, 2023

Conversation

kategengler
Copy link
Member

  • Also add a publish-to-branch workflow to see the built contents on a branch

@knownasilya knownasilya added breaking this will be a breaking change, and a new major version should be released internal labels Aug 16, 2023
@knownasilya
Copy link
Contributor

knownasilya commented Aug 16, 2023

@kategengler should the release readme mention how the automated publish works?

For example if I merge a pr with Breaking and then 10 minutes later merge another pr with Breaking, will that auto publish two new major versions?

@kategengler
Copy link
Member Author

This is not automated publishing. A person still needs to run npx release-it to create & push the tag that will trigger CI to publish. Details are in the RELEASE.md that is added

@kategengler
Copy link
Member Author

Taking that <3 as approval to merge ;)

@kategengler kategengler merged commit 0e4ce70 into master Aug 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the kg-add-ci-releasing branch August 16, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking this will be a breaking change, and a new major version should be released documentation internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants