Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated {{title}} ast transform #176

Merged
merged 4 commits into from
Sep 23, 2020

Conversation

knownasilya
Copy link
Contributor

BREAKING CHANGE: removes deprecated {{title}} ast transform, rename to {{page-title}}

BREAKING CHANGE: removes deprecated `{{title}}` ast transform, rename to `{{page-title}}`
@knownasilya knownasilya requested a review from rwjblue September 23, 2020 18:33
@knownasilya knownasilya changed the title fix: remove deprecated {{title}} at transform fix: remove deprecated {{title}} ast transform Sep 23, 2020
@knownasilya knownasilya added the breaking this will be a breaking change, and a new major version should be released label Sep 23, 2020
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great job!

addon/services/page-title-list.js Outdated Show resolved Hide resolved
}),

scheduleTitleUpdate() {
let router = getOwner(this).lookup('router:main');
let { activeTransition } = router._routerMicrolib;
// eslint-disable-next-line ember/no-private-routing-service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably remove this in a rebase now...

@knownasilya knownasilya merged commit 0c7b999 into master Sep 23, 2020
@knownasilya knownasilya deleted the fix/remove-deprecated-title-build branch September 23, 2020 20:39
@raido raido mentioned this pull request Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking this will be a breaking change, and a new major version should be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants