fix: title removed in tests

Also fixes a deprecation in dummy app
ember-cli · Jun 6, 2020 · b89ba58 · b89ba58
1 parent 39571b3
commit b89ba58
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 18 deletions.
diff --git a/tests/dummy/app/components/page-title-pane/component.js b/tests/dummy/app/components/page-title-pane/component.js
@@ -1,25 +1,10 @@
 import { A } from '@ember/array';
 import Component from '@ember/component';
 import { computed, set, get } from '@ember/object';
-import PageTitleList from 'ember-page-title/services/page-title-list';
-
-let TitleList = PageTitleList.extend({
-  _removeExistingTitleTag() {
-    return;
-  }
-});
-
 
 export default Component.extend({
-
   tagName: '',
 
-  titleList: computed({
-    get() {
-      return TitleList.create();
-    }
-  }),
-
   lastIndex: computed('titleList.tokens.length', {
     get() {
       return get(this, 'titleList.sortedTokens.length') - 1;

diff --git a/tests/dummy/app/controllers/application.js b/tests/dummy/app/controllers/application.js
@@ -0,0 +1,6 @@
+import Controller from "@ember/controller";
+import { inject as service } from "@ember/service";
+
+export default Controller.extend({
+  router: service(),
+});
diff --git a/tests/dummy/app/services/page-title-list.js b/tests/dummy/app/services/page-title-list.js
@@ -0,0 +1,7 @@
+import PageTitleList from 'ember-page-title/services/page-title-list';
+
+export default PageTitleList.extend({
+  _removeExistingTitleTag() {
+    return;
+  }
+});
diff --git a/tests/dummy/app/templates/application.hbs b/tests/dummy/app/templates/application.hbs
@@ -1,6 +1,6 @@
 {{! template-lint-disable simple-unless }}
 {{head-layout}}
-{{#unless (equals currentRouteName "index")}}
+{{#unless (equals this.router.currentRouteName "index")}}
   {{title "My App"}}
 {{/unless}}
-{{outlet}}
+{{outlet}}
diff --git a/tests/index.html b/tests/index.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <html>
   <head>
-    <title>ember-page-title tests</title>
     <meta charset="utf-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta name="description" content="">