fix: Use willDestroy() instead of destroy(). (#211)

Previous implementation did not call super.destroy() which means potentially some of super class functionality was not executed. From lifecycle perspective willDestroy() is better suited for teardown.
ember-cli · Feb 12, 2021 · 38fbc19 · 38fbc19
1 parent 72a940f
commit 38fbc19
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/addon/helpers/page-title.js b/addon/helpers/page-title.js
@@ -33,7 +33,8 @@ export default class PageTitle extends Helper {
     return '';
   }
 
-  destroy() {
+  willDestroy() {
+    super.willDestroy();
     this.tokens.remove(this.tokenId);
     this.tokens.scheduleTitleUpdate();
   }