Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ember-cli-babel 8 to version check #57

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Aug 26, 2023

WARNING: ember-compatibility-helpers: You are using an unsupported ember-cli-babel version, compatibility helper tranforms will not be included automatically
WARNING: ember-cli-typescript requires ember-cli-babel ^7.7.3, but you have version 8.0.0 installed; your TypeScript files may not be transpiled correctly.
WARNING: ember-compatibility-helpers: You are using an unsupported ember-cli-babel version, compatibility helper tranforms will not be included automatically
WARNING: ember-compatibility-helpers: You are using an unsupported ember-cli-babel version, compatibility helper tranforms will not be included automatically
WARNING: ember-compatibility-helpers: You are using an unsupported ember-cli-babel version, compatibility helper tranforms will not be included automatically
WARNING: ember-cli-typescript requires ember-cli-babel ^7.7.3, but you have version 8.0.0 installed; your TypeScript files may not be transpiled correctly.
WARNING: ember-compatibility-helpers: You are using an unsupported ember-cli-babel version, compatibility helper tranforms will not be included automatically
WARNING: ember-compatibility-helpers: You are using an unsupported ember-cli-babel version, compatibility helper tranforms will not be included automatically
WARNING: ember-cli-typescript requires ember-cli-babel ^7.1.0, but you have version 8.0.0 installed; your TypeScript files may not be transpiled correctly.

Comment on lines +56 to +57
name: 'ember-babel-8',
npm: {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we don't have a command in this scenario but we do for the others?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ember test is the default, afaik

@kategengler kategengler merged commit cd45be2 into ember-cli:master Oct 24, 2023
@kategengler
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants