Fixes the useLintTree: false scenario #87
Conversation
Tested on ember-cli 0.2.7, 1.13.8 & 1.13.8-master-1bd51615dc
| @@ -128,7 +128,8 @@ module.exports = { | |||
| lintTree: function(type, tree) { | |||
| // Skip if useLintTree === false. | |||
| if (this.options['ember-cli-qunit'] && this.options['ember-cli-qunit'].useLintTree === false) { | |||
| return tree; | |||
| // Fakes an empty broccoli tree | |||
| return { inputTree: tree, rebuild: function() { return []; } }; | |||
There was a problem hiding this comment.
You should be able to return false here if using Ember-CLI master.
There was a problem hiding this comment.
That would be less awesome towards people not yet able to migrate to the latest version of Ember-CLI.
There was a problem hiding this comment.
Very true. Forgot about that.
There was a problem hiding this comment.
This is compat with ember-cli 0.2.2+, but will not work for Broccoli 1.0.0 (where the .rebuild API is deprecated).
We will need to bump minors and just return false; at some point to avoid deprecations there (definitely fine to do at a later date when we use Broccoli 1.0.0 in ember-cli).
ghost
mentioned this pull request
|
Is anything blocking this PR? |
|
Don't think so. Probably just @rwjblue being tied up with other stuff? |
Fixes the useLintTree: false scenario
ghost
deleted the
|
@martndemus - Would you mind updating ember-cli-mocha to work similarly? |
|
@rwjblue Sure :) |
Addresses #83
Tested on ember-cli 0.2.7 & 1.13.8 & master