Handle jshinting via ember-cli's new 'lint' hooks #28
Conversation
| if (type === 'lint-app' || type === 'lint-tests' || type === 'lint-addon') { | ||
| return jshintTrees(tree, { | ||
| jshintrcPath: this.jshintrc.tests, | ||
| description: 'JSHint - QUnit' |
There was a problem hiding this comment.
Can this be 'JSHint - ' + type (otherwise they would all be reported as JSHint - QUnit)?
There was a problem hiding this comment.
Well, these are all QUnit specific. But I could also add the type.
There was a problem hiding this comment.
Yes, the point is the type. When this shows up in the slow trees log how do we know WHICH tree was slow?
|
One small nit-pick, but LGTM. |
Handle jshinting via ember-cli's new 'lint' hooks
|
@jakecraige - Can you release (and potentially add me to npm)? |
|
@dgeb - Will need to be mirrored in ember-cli-mocha. |
|
@dgeb I have a PR, I wasn't going to bother you until ember-cli releases. |
|
Apologies, but I found a problem with the way I originally did this. We want linters to run in parallel, not in series, so we can't use the existing postprocessTree hook. Please take #29 to switch. |
|
@ef4 should I hold off on merging ember-cli/ember-cli-mocha#26 ? |
|
ember-cli/ember-cli-mocha#26 is already updated to match my change above, but you may want to wait until the corresponding change lands in ember-cli: In case anybody else points out another reason the API would need to change. |
No description provided.