This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Upgrade QUnit to 2.0 #134
Merged
Upgrade QUnit to 2.0 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this against Ember Observer and all is passing. But it is dependent on https://github.com/rwjblue/ember-qunit/pull/234 being released first. I'll figure out why Travis is red in the meantime...
|
| @@ -1,6 +1,20 @@ | |||
| /* globals jQuery, QUnit, require, requirejs */ | |||
|
|
|||
| jQuery(document).ready(function() { | |||
| Ember.Test.QUnit2Adapter = Ember.Test.QUnitAdapter.extend({ | |||
There was a problem hiding this comment.
I'd like to move this into the ember-qunit suite, and not add to Ember.Test. Basically it would be:
import { QUnitAdapter } from 'ember-qunit';
|
I just released [email protected] with the changes from https://github.com/rwjblue/ember-qunit/pull/234, would you mind updating things here to match and smoke test? |
|
@rwjblue rebased this to use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corollary to https://github.com/rwjblue/ember-qunit/pull/234.
Only real change here is to provide a new test adapter for handling async. This might belong in
ember-qunitas opposed to this addon, but adding it here was way easier.