-
-
Notifications
You must be signed in to change notification settings - Fork 54
Refactor to use project's bower for deps. #13
Conversation
* Use ember-cli-qunit from ember-cli/ember-cli-qunit#13.
How is the generate handled when generating a new app? ember new myapp ? |
@jakecraige - It isn't, the generate only adds bower packages to |
I might add an |
@rwjblue I see how this fixes the immediate problem but I definitely think we need to figure out how addons should handle bower/npm dependencies. I'm thinking something similar to what you mentioned. Some way to "initialize" addons as a whole. In that they could specify things like adding bower or npm dependencies. Using blueprints seems like the wrong choice as they're going to get really confusing in that some create files and others do dependencies, some are required to run, some not. |
@@ -0,0 +1,28 @@ | |||
function installPackage(packageName, version) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You aren't actually using this function anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. Will remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
* Updates structure and export POJO from addon. * Remove bower.json. * Add `ember-cli-qunit` blueprint (that installs the bower packages).
We use blueprints to initialize an application, there is no reason that we should use something else (and recreate all of the functionality) to initialize an addon's use in an application. I plan on adding:
Either way, this PR is the correct direction for now (future changes to ember-cli simply make this even easier for us and our consumers). |
I could definitely see something like that command and hook being valuable. I'm for it yeah looks good |
Refactor to use project's bower for deps.
Yay |
ember-cli-qunit
blueprint (that installs the bower packages).Fixes #8.
Fixes #9.
Fixes #10.