This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Scale container with CSS transform instead of zoom #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSS `zoom` property is not standard — and doesn't work in Firefox (https://developer.mozilla.org/en-US/docs/Web/CSS/zoom). This MR scales down the test container with a CSS transform instead, which fixes the scaling on Firefox. Tested in Chrome 48, Firefox 46 and Safari 9.
|
@krisselden r?
|
| @@ -11,5 +11,8 @@ | |||
| margin: 0 auto; | |||
| } | |||
| #ember-testing { | |||
| zoom: 50%; | |||
| width: 200%; | |||
| height: 100%; | |||
There was a problem hiding this comment.
I don't think we want a specified height. Current behavior is that #ember-testing should grow as the content does so that way we still get scroll bars and such.
|
One comment, but otherwise this seems good. From messing around with it, this seems to address #48. |
|
Included in #123. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS
zoomproperty is not standard — and doesn't work in Firefox (https://developer.mozilla.org/en-US/docs/Web/CSS/zoom). This MR scales down the test container with a CSS transform instead, which fixes the scaling on Firefox.Tested in Chrome 48, Firefox 46 and Safari 9.